I think it's a very bad deal for the country but about as good as you could expect a Brexit deal given the 'red lines' that the UK put forward and the 'never possible' option that the EU would bend on any of its essential four pillars.
There are things which are positive. Gibraltar and the Cyprus bases get treated as if they were the UK. The British citizens in Europe and European citizens here are protected. From what I've read they are fewer demands on British businesses trading in Europe than for any third country and we are still able to transport goods without the third country restrictions (i.e. vehicle limits). There are, to my mind, very positive things in it about maintaining security cooperation and I imagine our GPS will keep working.
There are things that are negative. Most of those come from leaving the EU so there isn't a deal which would keep them. We've just lost the right to live and work in 27 other countries with minimal issue, for example. 80% of our economy - services - isn't included at all and is now effectively totally compromised.
There are things that are necessary. The insurance backstop for Northern Ireland that keeps the whole UK is one of those. Some people might like to stamp their feet about politicising a border but nobody - nobody - has yet come up with a solution that keeps that border 'soft' and handles divergence between Northern Ireland and Ireland.
And there are some things that were always going to be rubbish because the government doesn't care except when it's politically expedient to do so. See fishing as an example. But do bear in mind that a gung-ho no-deal Brexit would be worse even for fishing because whilst they may get the waters they wouldn't have anywhere to sell most of the catch. Most British fish is sold to Europe.
So it's an awful deal. In fact, not even a deal. It's a treaty that enables a transition after which a more formal deal may follow.
But it's an awful deal that is substantially better than No Deal. People like to squawk Project Fear even now but there really is no guarantee we would have enough medicine or food. We really would be unable to fly out of the country, access GPS or receive anti terrorist information. That's not Project Fear, it's just where we are. And we've got four months to sort out the sort of things that take 585 pages *between friends* to sort out if we want to avoid all that.
So. Put a gun against my head and say you have two options: This Deal or No Deal and I will obviously go for this deal. Because I'm obviously not patriotic enough to want to impoverish myself or my country any more than necessary. But it's not the best deal. The best deal is the one we have now. Full membership of the EU but with so many opt-outs it's almost like we're an independent sovereign nation talking in imperial measurements and driving on the other side of the road ...